Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expression: test evaluate method #534

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

mathause
Copy link
Member

@mathause mathause commented Oct 1, 2024

Added tests for expr.evaluate - I will do some more refactoring of the method later but wanted to get some tests in first.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.00%. Comparing base (660c45c) to head (4b1d20a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #534      +/-   ##
==========================================
+ Coverage   61.80%   62.00%   +0.19%     
==========================================
  Files          50       50              
  Lines        3561     3561              
==========================================
+ Hits         2201     2208       +7     
+ Misses       1360     1353       -7     
Flag Coverage Δ
unittests 62.00% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mathause
Copy link
Member Author

mathause commented Oct 1, 2024

  • I don't test forced_shape - not sure if that is really needed - do we ever pass arrays with more than 1D?
  • I am also not sure that I test every possibility
  • do we actually need to broadcast scalar coeffs? I expect scalars to just work. Would be good to have a failure case for that.

@mathause
Copy link
Member Author

mathause commented Oct 1, 2024

Thanks

@mathause mathause merged commit 72d2fd9 into MESMER-group:main Oct 1, 2024
9 checks passed
@mathause mathause deleted the test_expression_evaluate branch October 1, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants